Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community Batch Imports: add links between "Pending Imports" and "New Imports" pages for easier navigation. #10285

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ananyakaligal
Copy link
Contributor

Closes #10154

What does this PR achieve?
This PR adds navigation links between the "Pending Imports" and "New Imports" pages for easier access. It enhances the user experience by providing direct links at the bottom of both pages, facilitating smoother transitions between the two sections.

Technical
Created a new Macro BatchImportNavigation.html to include the navigation links.
Updated the templates batch_import_view.html and batch_import_pending_view.html pages to include the new navigation menu via :macros.BatchImportNavigation().

Testing
Visit the "Pending Imports" page (/import/batch/pending) or "New Imports" page (/import/batch/new) and ensure there’s a navigation bar created for both the links.

Screenshot
400215213-7f4f77ed-2a9e-4798-9999-7142f6b8d8d3
400215402-6107fd9b-4787-42ba-ac44-a82afb06529e

Stakeholders
@RayBB, @scottbarnes

@ananyakaligal ananyakaligal changed the title Community Batch Imports: add links between "Pending Imports" and "New Imports" pages for easier navigation. #10154 Community Batch Imports: add links between "Pending Imports" and "New Imports" pages for easier navigation. Jan 6, 2025
@RayBB RayBB assigned scottbarnes and unassigned RayBB Jan 7, 2025
@RayBB
Copy link
Collaborator

RayBB commented Jan 7, 2025

@ananyakaligal at first glance this looks great.
Unfortunately, I'm having some issues with my local environment to test this that I can't debug now.
column "submitter" does not exist LINE 2: ...) AS comments, MIN(added_time) AS added_time, MAX(submitter)... ^

Perhaps @scottbarnes could review and merge as he's also worked on this feature? :)

@RayBB RayBB added the Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. label Jan 7, 2025
@ananyakaligal
Copy link
Contributor Author

@RayBB I encountered the same issue, and I even addressed it to you previously. My approach to this was by adding the 'Submitter' column to the database in my local environment. It worked perfectly fine after that.

@RayBB
Copy link
Collaborator

RayBB commented Jan 7, 2025

@ananyakaligal could you do me a favor and create a GitHub issue for this? We should add this column to the data auto loaded when someone creates a local insurance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this.
Projects
Status: Waiting Review/Merge from Staff
Development

Successfully merging this pull request may close these issues.

Community Batch Imports: add links between "Pending Imports" and "New Imports" pages for easier navigation.
3 participants