Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fold all updates since May from master and internal repo into v1 #437

Merged
merged 59 commits into from
Apr 12, 2024

Conversation

isc-tleavitt
Copy link
Contributor

This also includes some in-progress changes to the packages workflow (will be handled separately, this at least moves the ball forward there although it isn't done yet).

This includes through internal revision 6487010.

evshvarov and others added 30 commits May 13, 2023 11:02
Fixes #416

This just changes tar generation, so it's actually backward-compatible with old IPM versions loading the package. (Which is neat.)
Update readme to add one-liner to install IPM
Use prefix to work around filename length limits
Fix install for certain non-enuw locales
fixed installing python dependencies for ipm dependencies
Set up for `intersystems-community.testingmanager` VS Code extension
Set the ^UnitTestRoot node when building the container
add zpm version and current registry on entrance
EnableEnsemble for Verify stage
Eventually...
Strip newlines
Move packages to attribute?
Change quoting approach to see if this works better?
Maybe needs else?
Raise threshold while in testing
@isc-tleavitt
Copy link
Contributor Author

isc-tleavitt commented Jan 29, 2024

@isc-shuliu in case you get to the CI failures before I do, there are three classes of issues:

  • Failures early because of our processing of tags - we're turning e.g. latest-em and latest-cd into "latest" which doesn't exist. Need to be smarter here.
  • Failures early because of community edition licenses expiring - we should detect and fail early (without an error) in this case. If there's some kind of "skipped" option for the job that is neither success nor failure that would be ideal, if possible.
  • Failures later in the process because of the ZPM->IPM rename (this is a bigger can of worms I don't expect you to open just yet ;))

Also, we only want the highest value of z among builds (year.x.y.z)

isc-tleavitt and others added 18 commits January 30, 2024 09:55
e.g. with:
act -j "build" --input IMAGE="[\"iris-community:latest-em\"]"
Easier to run via act for testing.
We now omit old previews and no longer truncate valid tags containing dashes
Running locally on act, would previously leave the registry and zpm network after failure.
Mounts don't seem to work properly in act, so copying files instead.
Fix Default.Document resource processor to not force a category subdirectory
ci: parameterize minVersionCount for packages.yml
@isc-tleavitt
Copy link
Contributor Author

isc-tleavitt commented Feb 1, 2024

@isc-shuliu here's an updated checklist after the work I did earlier this week:

  • Be smarter about expired community edition licenses; could have a min version flag or a file with a list of tags to ignore? (need this in master and v1)
  • Issues in the clean install step (this is likely to be the bigger can of worms, but we can at least investigate + fix the missing container part)
  • Fix unit tests (currently have a failure due to a code change) - we might need to talk about the code change
  • Fix "verify" phase (currently failing due to ZPM/IPM differences)
  • Ensure "verify" passes
  • Make test/verify failures fatal again
  • Really fix clean install + upgrade (this one is on me and is likely enormous)

isc-shuliu and others added 6 commits February 1, 2024 13:28
Add CI to test major packages on v1-jan-2024-updates branch
ModuleItem is the table name; should have checked for Module class.
Looking at history these were added fairly recently and it's failing here, so maybe removing them will fix it.
@isc-tleavitt isc-tleavitt mentioned this pull request Apr 12, 2024
8 tasks
@isc-tleavitt
Copy link
Contributor Author

All changes since the last approving reviews have been CI-related. There's still some preexisting tech debt there; captured it in #451 but merging this now so we can keep targeting v1 with more granular changes.

@isc-tleavitt isc-tleavitt merged commit f2fea39 into v1 Apr 12, 2024
19 of 28 checks passed
@isc-tleavitt isc-tleavitt deleted the v1-jan-2024-updates branch April 12, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants