fix: IPM works with delimited identifiers disabled #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also picks up a fix for a stray failing unit test - ${verbose} / {$verbose} weren't working in expression evaluation
isc-kiyer
reviewed
Apr 9, 2024
| @@ -10,7 +10,7 @@ Property Name As %String(MAXLEN = 2048, XMLPROJECTION = "attribute") [ Required | |||
| /// Name index is unique per namespace. | |||
| Index ResourceName On (Name, Source); | |||
|
|
|||
| Relationship Module As %IPM.Storage.Module(XMLPROJECTION = "NONE") [ Cardinality = parent, Inverse = Mappings ]; | |||
| Relationship Module As %IPM.Storage.Module(XMLPROJECTION = "NONE") [ Cardinality = parent, Inverse = Mappings, SqlFieldName = _MODULE ]; | |||
There was a problem hiding this comment.
@isc-tleavitt For consistency, would make sense to call this ModuleItem to match the SqlTableName of %IPM.Storage.Module
There was a problem hiding this comment.
Fair point; I'll do this everywhere I'd updated to _MODULE
For consistency with SqlTableName of %IPM.Storage.Module
|
Needs a CHANGELOG.md update too - I want to get #452 merged and in here (which'll be a conflict anyway) so we can get a better idea of build cleanness. |
isc-kiyer
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also picks up a fix for a stray failing unit test - ${verbose} / {$verbose} weren't working in expression evaluation
Fixes #440