Remove extra _catalog call when installing from oras repo #669
+37
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an oras repo Without the _catalog call, it is already enough to do all necessary filtering for oras package installs. Doing the _catalog call is unnecessary. As _catalog is also not part of oci specs, per opencontainers/distribution-spec#22 , the return behavior is also undefined, which can cause the install commands to fail depending on the specific implementation of the OCI registry, such as in JFrog Artifactory when combined with namespaces. Signed-off-by: Eric Chen <echen@intersystems.com>
|
Weird it didn't trigger a CI run. Let me see if I can start that manually. |
Signed-off-by: Eric Chen <echen@intersystems.com>
isc-shuliu
requested review from
isc-kiyer,
isc-shuliu,
isc-tleavitt,
isc-eneil,
isc-jili and
isc-jlechtne
|
The CIs are only failing for images with |
|
The problem is here |
|
@isc-shuliu your hypothesis is right. The error comes from the issue described in https://usjira.iscinternal.com/browse/HSIEO-11639. The DeepSeeEnabled and iKnowEnabled properties were updated to have type %Installer.Boolean in the PR you linked. |
|
Updated from v0.10.x, that should do it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the _catalog call, it is already enough to do all necessary filtering for oras package installs. Doing the _catalog call is unnecessary.
As _catalog is also not part of oci specs, per opencontainers/distribution-spec#22 , the return behavior is also undefined, which can cause the install commands to fail depending on the specific implementation of the OCI registry, such as in JFrog Artifactory when combined with namespaces. (_catalog calls occur against the domain regardless of namespaces, FQDN/v2/_catalog, and returns only the path of the package, not including the namespace. The prior filtering then tries to filter for namespace/package, which fails, however FQDN/v2/namespace/package is valid)