Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(analytics): deprecation warning for v8 API ahead of future major release #8197

Draft
wants to merge 1 commit into
base: v8-deprecations
Choose a base branch
from

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Dec 20, 2024

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 11:03am

@russellwheatley
Copy link
Member Author

russellwheatley commented Dec 20, 2024

@mikehardy - Started this and I wanted to get your thoughts on the modular event methods we've ported over.

The firebase-js-sdk doesn't have methods for every event, they just have logEvent() to be used for custom and reserved events: https://firebase.google.com/docs/reference/js/analytics

Wondering whether we should deprecate all the modular methods we've ported over and just use logEvent()?

examples: https://github.com/invertase/react-native-firebase/blob/main/packages/analytics/lib/modular/index.js#L165-L187

Part of me thinks they're useful but another part thinks we should stick to firebase-js-sdk API 🤔

@russellwheatley russellwheatley changed the title chore(core): deprecation warning for v8 API ahead of future major release chore(analytics): deprecation warning for v8 API ahead of future major release Dec 20, 2024
@mikehardy
Copy link
Collaborator

@russellwheatley Deviating from firebase-js-sdk API is a slippery slope and at least personally I can only justify it when there is a native method that's really useful and has no analog we can do with firebase-js-sdk - logEvent seems sufficient as an analog, to me. I don't think the specific methods meet the bar to justify deviation from firebase-js-sdk, so I'd deprecate them and go 100% JS API here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants