Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant app.config.js support #606

Merged

Conversation

DoctorJohn
Copy link
Contributor

Description

This PR removes the redundant and deprecated handling of app.config.js files from the ios_config.sh and build.gradle scripts.

Now that app.config.js support is handled by the Expo config plugin, the ios_config.sh and build.gradle scripts no longer need to consider app.config.js at all. Parts of the code added in #517 can be removed again to make the scripts easier to maintain. That's exactly what this PR does. It's simply reverting all changes to the relevant files from said PR. I double checked that this does only revert the app.config.js support and nothing else (e.g. fixes or other refactorings).

Checklist

  • I read the Contributor Guide
    and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in __tests__e2e__
    • jest tests added or updated in __tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

  • Ran our tests
  • Made sure the example app still works

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.66%. Comparing base (a34c7ba) to head (5f10dd5).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
- Coverage   43.72%   42.66%   -1.06%     
==========================================
  Files          30       31       +1     
  Lines         549      565      +16     
  Branches      151      154       +3     
==========================================
+ Hits          240      241       +1     
- Misses        309      324      +15     

@DoctorJohn DoctorJohn force-pushed the revert-deprecated-app-config-js-support branch from 1bdbfc8 to 5366215 Compare July 12, 2024 17:11
ios_config.sh Show resolved Hide resolved
@DoctorJohn DoctorJohn force-pushed the revert-deprecated-app-config-js-support branch from 5366215 to 52871f9 Compare July 13, 2024 13:44
@DoctorJohn DoctorJohn force-pushed the revert-deprecated-app-config-js-support branch from 52871f9 to 5f10dd5 Compare July 13, 2024 13:49
@dylancom dylancom merged commit 5c0c0bd into invertase:main Jul 14, 2024
11 of 12 checks passed
@dylancom
Copy link
Collaborator

Good catch👍

@mikehardy
Copy link
Collaborator

🎉 This PR is included in version 14.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants