CMAKE: added cmake build support #559
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgerhardy
commented
Apr 23, 2022
| @@ -0,0 +1,34 @@ | |||
| if (MSVC) | |||
| set(SDL2_INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}/include CACHE STRING "") | |||
There was a problem hiding this comment.
In WorldOfPadman we have solved this like this: https://github.com/PadWorld-Entertainment/worldofpadman/blob/main/libs/CMakeLists.txt#L10
if (UNIX)
find_package(PkgConfig REQUIRED)
pkg_check_modules(SDL2 REQUIRED sdl2)
add_library(SDL2_system INTERFACE)
add_library(SDL2_main INTERFACE)
target_include_directories(SDL2_system INTERFACE ${SDL2_INCLUDE_DIRS})
target_link_libraries(SDL2_system INTERFACE ${SDL2_LINK_LIBRARIES})
add_library(SDL2::SDL2 ALIAS SDL2_system)
add_library(SDL2::SDL2main ALIAS SDL2_main)
else()
set(OUTPUT_DIRECTORY "${ROOT_DIR}/${ENGINE_BINARY_DIR}")
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_DEBUG "${OUTPUT_DIRECTORY}")
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_RELEASE "${OUTPUT_DIRECTORY}")
set(CMAKE_LIBRARY_OUTPUT_DIRECTORY_DEBUG "${OUTPUT_DIRECTORY}")
set(CMAKE_LIBRARY_OUTPUT_DIRECTORY_RELEASE "${OUTPUT_DIRECTORY}")
set(SDL_CMAKE_DEBUG_POSTFIX "" CACHE STRING "Name suffix for debug builds")
add_subdirectory(SDL2)
endif()We have an SDL2 clone in our repository - which is a lot easier to update and maintain than building the needed libs each time.
Open
mgerhardy
commented
Sep 3, 2023
| if (CMAKE_SIZEOF_VOID_P EQUAL 8) | ||
| set_property(SOURCE ${_file} APPEND PROPERTY COMPILE_DEFINITIONS idx64=1) | ||
| endif() | ||
| set_property(SOURCE ${_file} APPEND PROPERTY LANGUAGE ASM_MASM) |
There was a problem hiding this comment.
set_source_files_properties(${_file} PROPERTIES COMPILE_FLAGS "/safeseh")
is missing here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old PR was this #517 - but I deleted the repo by accident.