Set the maximum file limit for POSIX systems #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acronce
commented
Dec 4, 2022
acronce
commented
- Resolves an issue I saw where the macOS application's dylibs could not be loaded because I had too many maps.
- Due to not so great error logging, this problem was non-obvious. Ultimately I managed to spot the error 24, which is means too many open files.
- On macOS the default number of open files is 256 (without this change).
- The Windows implementation currently does nothing, but that's reasonable because the limit is quite large (10k I think).
- Resolves an issue I saw where the macOS application's dylibs could not be loaded because I had too many maps. - Due to not so great error logging, this problem was non-obvious. Ultimately I managed to spot the error 24, which is means too many open files. - On macOS the default number of open files is 256 (without this change). - The Windows implementation currently does nothing, but that's reasonable because the limit is quite large (10k I think).
- Simplified the implementation and made it more POSIX based and less macOS. - Handle the rare failure case on older macOS versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.