Fix stack usage validation for eBPF local functions #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkinsw
force-pushed
the
local_function_stack_usage_fix
branch
4 times, most recently
from
5f2b762 to
8ae6ff2
Compare
Alan-Jowett
reviewed
Oct 16, 2024
custom_tests/srcs/ubpf_test_custom_local_function_stack_size.cc
Outdated
Show resolved
Hide resolved
Stack usage for eBPF local functions was incorrectly calculated whether or not a custom stack usage calculator was present or not. This PR fixes that issue. In addition to fixing that bug, this PR also changes the default eBPF program stack size and the default stack size for local functions in eBPF programs (8K and 256 bytes, respectively). This PR also adds support for a stack usage calculator that does not want to allow an eBPF program's local functions to use any stack space at all. Signed-off-by: Will Hawkins <hawkinsw@obs.cr>
hawkinsw
force-pushed
the
local_function_stack_usage_fix
branch
from
8ae6ff2 to
fae1535
Compare
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Alan-Jowett
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack usage for eBPF local functions was incorrectly calculated whether or not a custom stack usage calculator was present or not. This PR fixes that issue.
In addition to fixing that bug, this PR also changes the default eBPF program stack size and the default stack size for local functions in eBPF programs (8K and 256 bytes, respectively).
This PR also adds support for a stack usage calculator that does not want to allow an eBPF program's local functions to use any stack space at all.