Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how camera intrinsics are used for creation and update #1624

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jtigue-bdai
Copy link
Collaborator

@jtigue-bdai jtigue-bdai commented Jan 3, 2025

Description

This PR changes how the camera intrinsic matrix:

  • Is used to create usd cameras
  • Is updated from usd camera parameters

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@jtigue-bdai jtigue-bdai self-assigned this Jan 3, 2025
@jtigue-bdai
Copy link
Collaborator Author

@pascal-roth here is that camera intrinsic PR I was talking about.

@jtigue-bdai jtigue-bdai marked this pull request as ready for review January 3, 2025 15:37
Copy link
Collaborator

@pascal-roth pascal-roth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job to remove the code duplication.

I don't know if the focal length of 1/width is a common standard in the literature. What is your source for that? Otherwise, picking that as a default seems a bit arbitrary.

Comment on lines +211 to 214
The intrinsic matrix is used to set the following parameters to the USD camera:

- ``focal_length``: The focal length of the camera.
- ``horizontal_aperture``: The horizontal aperture of the camera.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the case, isn't it? The focal_length is not set over the intrinsic matrix but just over the width. We should rephrase that to prevent confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants