Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop use of non-initialized variables #992

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Drop use of non-initialized variables #992

wants to merge 1 commit into from

Conversation

sthibaul
Copy link

@sthibaul sthibaul commented Nov 3, 2024

No description provided.

imaami
imaami approved these changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@imaami imaami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Btw, this same bug is also in JackBoomerDriver::DisplayDeviceInfo().

@imaami
Copy link
Contributor

imaami commented Jan 1, 2025

@falkTX this is about as trivial of a fix as it gets, would be nice to see it merged.

@sthibaul
Drop use of non-initialized variables
ba9ac34 
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
@sthibaul
Copy link
Author

sthibaul commented Jan 2, 2025

Btw, this same bug is also in JackBoomerDriver::DisplayDeviceInfo().

Indeed, now fixed there as well.

imaami
imaami approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@imaami imaami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imaami imaami imaami approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sthibaul @imaami