Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] enforce perflint checks #190

Merged
merged 2 commits into from
Nov 2, 2023
Merged

[ci] enforce perflint checks #190

merged 2 commits into from
Nov 2, 2023

Conversation

jameslamb
Copy link
Owner

Proposes enforcing the perflint checks in this project's CI.

Fixes the following:

src/pydistcheck/checks.py:122:29: PERF102 When using only the values of a dict use the `values()` method
tests/test_distribution_summary.py:86:29: PERF102 When using only the values of a dict use the `values()` method
tests/test_distribution_summary.py:203:29: PERF102 When using only the values of a dict use the `values()` method

For more, see https://github.com/tonybaloney/perflint and https://docs.astral.sh/ruff/rules/#perflint-perf.

@jameslamb jameslamb added the maintenance Not a bug or feature label Nov 2, 2023
@jameslamb jameslamb merged commit f49d76c into main Nov 2, 2023
18 checks passed
@jameslamb jameslamb deleted the ci/perflint branch November 2, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant