Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] improve zstandard error message #286

Closed
wants to merge 2 commits into from

Conversation

Inifomeeo
Copy link
Contributor

@Inifomeeo Inifomeeo commented Dec 24, 2024

Fixes #284

@Inifomeeo Inifomeeo requested a review from jameslamb as a code owner December 24, 2024 19:42
@jameslamb jameslamb changed the title Release/v0.8.1 [docs] improve zstandard error message Dec 24, 2024
@jameslamb jameslamb added the doc Improvements or additions to documentation label Dec 24, 2024
Copy link
Owner

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for taking the time to contribute!

I've changed the title of this and left a suggestion... let's please keep this focused on just this change and not also on trying to immediately do a release. In this project, every commit does not automatically become a release... groups of changes are batched together and released whenever enough unreleased stuff piles up on main.

@@ -1,4 +1,4 @@
# no one should be importing from this package
__all__ = [] # type: ignore[var-annotated]

__version__ = "0.8.0.99"
__version__ = "0.8.1"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
__version__ = "0.8.1"
__version__ = "0.8.0.99"

Please revert this. This change won't be immediately released.

@Inifomeeo Inifomeeo closed this Dec 25, 2024
@Inifomeeo Inifomeeo deleted the release/v0.8.1 branch December 25, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve zstandard error message
2 participants