Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new] unify pandoc exec call #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thendarion
Copy link

it was weird that pandoc was called differently on windows and linux even though it was passed the same exact parameters, so here's a proposal to use the same call on both platforms

@thendarion
Copy link
Author

not sure what happened there. sonarcloud didn't even run?

@jason-fox
Copy link
Owner

Have you tested this on Windows? The reason for the current split is because the ANT exec task is doing different things in Windows and Unix - Windows is spawning a command shell, Unix isn't.

@jason-fox
Copy link
Owner

not sure what happened there. sonarcloud didn't even run?

It is to do with the GitHub Action setup. Sonar Cloud requires the ${{ secrets.SONAR_CLOUD_LOGIN }} which is set up in the repository settings. For some reason this secret hasn't been read in on the PR. Weird.

@thendarion
Copy link
Author

unfortunately in my Windows 10 environment this change was necessary to make it work

@jason-fox
Copy link
Owner

unfortunately in my Windows 10 environment this change was necessary to make it work

Nothing like consistency eh? I'll need to find an environment do some Windows 7,8, 10 testing I guess.

@jason-fox
Copy link
Owner

jason-fox commented Jul 1, 2021

Do the changes made for 162572b (effectively allowing the user to supply a path to Pandoc) help resolve this issue?

@thendarion
Copy link
Author

I'll check and get back to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants