Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v5.0.1 #877

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Prepare v5.0.1 #877

merged 2 commits into from
Oct 26, 2023

Conversation

rtpg
Copy link
Contributor

@rtpg rtpg commented Oct 26, 2023

This just tags the requirements properly.

@jezdez I think we want to yank 5.0.0 (after I release 5.0.!), just because Django 3.2 is an LTS release so until mid-2024. Is there a process that would allow me to do yanking on Pypi?

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #877 (b5ded0d) into master (ee1e98c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #877   +/-   ##
=======================================
  Coverage   92.31%   92.31%           
=======================================
  Files           9        9           
  Lines         729      729           
  Branches      131      131           
=======================================
  Hits          673      673           
  Misses         36       36           
  Partials       20       20           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rtpg rtpg merged commit 1b241a3 into master Oct 26, 2023
10 checks passed
@jezdez
Copy link
Member

jezdez commented Oct 26, 2023

@rtpg No, yanking isn't implemented on the Jazzband side since it predates the PyPI feature, but I can do that manually.

@rtpg
Copy link
Contributor Author

rtpg commented Oct 30, 2023

Alright, 5.0.1 (which fixes the constraints)

@jezdez would you be able to yank the 5.0.0 release? My understanding of yanking is that people who have pinned to 5.0.0 will still have access to it (fine!) but people who install without pinning will not have it proposed to them (good, because 5.0.0's django requirements state 3.2 support when it's in fact not supporting 3.2). So people who want 5.0.0 can still have it, and people on Django 3.2 will not be offered an incompatible release anymore.

@jezdez
Copy link
Member

jezdez commented Oct 30, 2023

@rtpg Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants