Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing 3.8 #925

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Removing 3.8 #925

merged 2 commits into from
Oct 18, 2024

Conversation

guel-codes
Copy link
Contributor

@guel-codes guel-codes commented Oct 18, 2024

Overview:
This PR is mainly for cleanup. Now that Python 3.8 has officially reached EoL, it is time to remove support for that version.
This refers to #900

Updates:
These 2 are probably the most important for review since they handle CI/CD workflows

  • .github/workflows/release.yml
  • .github/workflows/test.yml

########################

  • CHANGELOG.rst
  • docs/index.rst
  • setup.cfg
  • taggit/__init__.py
  • tox.ini

@guel-codes guel-codes requested a review from rtpg October 18, 2024 05:48
@@ -1,2 +1,2 @@
VERSION = (6, 1, 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's avoid bumping this up for now, we'll bump it up once we make a release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 🙌🏽

py{310,311,312}-dj{50}
py{310,311,312}-djmain
docs

[gh-actions]
python =
3.8: py38, black, flake8, isort
3.9: py39
3.9: py39, black, flake8, isort
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see we didn't lose these, that was one thing I was worried about

@rtpg rtpg merged commit e41b5fc into jazzband:master Oct 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants