-
-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #691 - Obsolete THUMBNAIL_KVSTORE #692
Conversation
Codecov Report
@@ Coverage Diff @@
## master #692 +/- ##
==========================================
+ Coverage 73.75% 73.80% +0.04%
==========================================
Files 30 30
Lines 1688 1691 +3
==========================================
+ Hits 1245 1248 +3
Misses 443 443
Continue to review full report at Codecov.
|
Please just wait a bit before reviewing this patch, there are some things I'd want to check before going forward. |
@claudep Convert this PR to draft? It's from 2022. |
@claudep how about remove the support without deprecating and release major release with a breaking change 😉 |
I think we can release a 12.x version with the deprecation, and not so long after release a 13.x version with the removals. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@claudep may I merge this PR, it looks good to me. |
Thanks for the review! |
No description provided.