Switch Note.id from Integer to Long (#1706)

* Switch Note.id from Integer to Long GitLab has changed the data type of the Note id field from int to bigint. Fixes #1705 #1705 (comment) describes the issue in more detail. * NoteObjectAttributes.id needs to be Long also --------- Co-authored-by: Kris Stern <krisstern@outlook.com>
jenkinsci · Oct 11, 2024 · 804a294 · 804a294
1 parent 3f2cfd8
commit 804a294
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/src/main/java/com/dabsquared/gitlabjenkins/gitlab/api/model/Note.java b/src/main/java/com/dabsquared/gitlabjenkins/gitlab/api/model/Note.java
@@ -8,7 +8,7 @@
 
 @GeneratePojoBuilder(intoPackage = "*.builder.generated", withFactoryMethod = "*")
 public class Note {
-    private Integer id;
+    private Long id;
     private Integer projectId;
     private User author;
     private Date createdAt;
@@ -17,11 +17,11 @@ public class Note {
 
     public Note() {}
 
-    public Integer getId() {
+    public Long getId() {
         return id;
     }
 
-    public void setId(Integer id) {
+    public void setId(Long id) {
         this.id = id;
     }
 

diff --git a/src/main/java/com/dabsquared/gitlabjenkins/gitlab/hook/model/NoteObjectAttributes.java b/src/main/java/com/dabsquared/gitlabjenkins/gitlab/hook/model/NoteObjectAttributes.java
@@ -12,19 +12,19 @@
 @GeneratePojoBuilder(intoPackage = "*.builder.generated", withFactoryMethod = "*")
 public class NoteObjectAttributes {
 
-    private Integer id;
+    private Long id;
     private String note;
     private Integer authorId;
     private Integer projectId;
     private Date createdAt;
     private Date updatedAt;
     private String url;
 
-    public Integer getId() {
+    public Long getId() {
         return id;
     }
 
-    public void setId(Integer id) {
+    public void setId(Long id) {
         this.id = id;
     }
 

diff --git a/...ava/com/dabsquared/gitlabjenkins/trigger/handler/note/NoteHookTriggerHandlerImplTest.java b/...ava/com/dabsquared/gitlabjenkins/trigger/handler/note/NoteHookTriggerHandlerImplTest.java
@@ -72,7 +72,7 @@ public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, BuildListen
                 project,
                 noteHook()
                         .withObjectAttributes(noteObjectAttributes()
-                                .withId(1)
+                                .withId(1L)
                                 .withNote("ci-run")
                                 .withAuthorId(1)
                                 .withProjectId(1)
@@ -119,7 +119,7 @@ public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, BuildListen
                 project,
                 noteHook()
                         .withObjectAttributes(noteObjectAttributes()
-                                .withId(1)
+                                .withId(1L)
                                 .withNote("ci-run")
                                 .withAuthorId(1)
                                 .withProjectId(1)