Ensure a redirect of the HttpServletResponse will close HttpOutput #12633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
lachlan-roberts
added
the
Sponsored
sbordet
previously approved these changes
Dec 12, 2024
gregw
requested changes
Dec 12, 2024
...ee10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/ServletApiResponse.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
|
@gregw please re-review |
gregw
approved these changes
Dec 16, 2024
|
What are the chances this makes the next release? Also, @lachlan-roberts, how soon after release will this make it into App Engine? |
|
@MuffinTheMan This will make it into the next release of After this is released I will update GAE to You could build Jetty and GAE yourself and deploy your application with this fix if you need it earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the GAE issue GoogleCloudPlatform/appengine-java-standard#321, a redirect is being done from a JSP file with non-empty content.
In Jetty 9.4 and EE8 we would close the
HttpOutputduring the call tosendRedirect, and so any further content that is tried to send should throwIOException.