Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jaas index.adoc #12634

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

karstenhusberg
Copy link
Contributor

There is no ee10-jaas module, or ee8-jaas or ee8-jaas as far as I can see and module 'jaas' made it work in my ee10 set-up.

There is no ee10-jaas module, or ee8-jaas or ee8-jaas as far as I can see and module 'jaas' made it work in my ee10 set-up.
@janbartel janbartel self-assigned this Dec 12, 2024
@janbartel
Copy link
Contributor

@karstenhusberg can you also add one more change to this PR? The jetty-ee10/jetty-ee10-webapp/src/main/java/org/eclipse/jetty/ee10/webapp/JaasConfiguration.java class refers to the package org.eclipse.jetty.ee10.jaas which doesn't exist, at this line: https://github.com/jetty/jetty.project/blob/jetty-12.0.x/jetty-ee10/jetty-ee10-webapp/src/main/java/org/eclipse/jetty/ee10/webapp/JaasConfiguration.java#L38`

Copy link
Contributor

@janbartel janbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment about making one extra little change.

remove reference to non-existing package
@karstenhusberg
Copy link
Contributor Author

@janbartel I've updated as per your request. Unfortunately I never got what I intented to do to work and now I must hurry on to other tracks. I was supposed to JNDI-publish a jakarta.mail.Session as described here https://jetty.org/docs/jetty/12/operations-guide/jndi/index.html#mail but when looking it up from within my application I only got a MailSessionReference object not a Session. Probably me doing some obvious error :-)

@janbartel janbartel merged commit f476a58 into jetty:jetty-12.0.x Dec 18, 2024
10 checks passed
@janbartel
Copy link
Contributor

Thanks @karstenhusberg, I've merged your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants