Port ee9 BlockingTest to ee10/11
#12635
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban
changed the title
BlockingTest to ee10 and ee11BlockingTest to ee10/11
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
…ee10-BlockingTest
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
This reverts commit b6a7854.
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting ee9 BlockingTest to ee10/11 seems to have uncovered some bugs.
There are still some bugs in ee9 too, uncovered by the new
testBlockingCloseWhileReadingtest:asyncContext.complete()throws after the connection was closed by the client. Historically, this test tolerated these exceptions though.outputStream.close()sometimes throwsjava.lang.IllegalArgumentException: newPosition > limit: (9 > 0)which tend to indicate a buffer use after release.