Issue #12609 - better validation for response codes in setStatus #12643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
gregw
requested changes
Dec 16, 2024
Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
|
@gregw this came up because there was a change in behavior testing sendError on GAE, so I think its worth keeping it for
good point, fixed now |
gregw
reviewed
Dec 16, 2024
| @@ -754,7 +754,7 @@ public void addIntHeader(String name, int value) | |||
| @Override | |||
| public void setStatus(int sc) | |||
| { | |||
| if (sc <= 0) | |||
| if (sc < 100 || sc > 999) | |||
There was a problem hiding this comment.
I assume that if we didn't check here the core response check would eventually throw? But probably best to check here so the throw comes at the expected method rather than a later flush
gregw
approved these changes
Dec 16, 2024
janbartel
approved these changes
Dec 19, 2024
lachlan-roberts
added
the
Sponsored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12609