Improve message for asciidoc input error #8416 #10492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgm
reviewed
Dec 23, 2024
src/Text/Pandoc/Error.hs
Outdated
Comment on lines
127
to
128
| "asciidoc" -> "\nPandoc can convert to asciidoc, but not from " <> | ||
| "\n asciidoc (sometimes adoc also)." |
There was a problem hiding this comment.
I'd prefer a simpler one liner "Pandoc can convert to asciidoc, but not from asciidoc."
foursixnine
force-pushed
the
alittlebitmoreverboseinmycli
branch
from
d82554f to
13d5903
Compare
foursixnine
force-pushed
the
alittlebitmoreverboseinmycli
branch
from
13d5903 to
20b2492
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that asciidoct is not supported as input format, so in this case its
better to be clear about what the failure is about.
This should improve the error being presented to the user.