Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small lint fixes #381

Merged
merged 1 commit into from
Dec 27, 2024
Merged

small lint fixes #381

merged 1 commit into from
Dec 27, 2024

Conversation

jkroepke
Copy link
Owner

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

  • fixes #

Special notes for your reviewer

Particularly user-facing changes

Checklist

Complete these before marking the PR as ready to review:

  • DCO signed
  • The PR title has a summary of the changes
  • The PR body has a summary to reflect any significant (and particularly user-facing) changes introduced by this PR

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke added the chore small nits label Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.15%. Comparing base (e3f9ec9) to head (d86fc90).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/daemon/root.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
+ Coverage   82.82%   83.15%   +0.33%     
==========================================
  Files          50       50              
  Lines        2859     2856       -3     
==========================================
+ Hits         2368     2375       +7     
+ Misses        376      367       -9     
+ Partials      115      114       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkroepke jkroepke merged commit b9bba17 into main Dec 27, 2024
9 checks passed
@jkroepke jkroepke deleted the fixes branch December 27, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore small nits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant