Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: more coverage #44

Merged
merged 8 commits into from
Oct 6, 2023
Merged

tests: more coverage #44

merged 8 commits into from
Oct 6, 2023

Conversation

jkroepke
Copy link
Owner

@jkroepke jkroepke commented Oct 6, 2023

Signed-off-by: Jan-Otto Kröpke mail@jkroepke.deWhat this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Particularly user-facing changes:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • The PR title has a summary of the changes
  • The PR body has a summary to reflect any significant (and particularly user-facing) changes introduced by this PR

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (034cc29) 72.99% compared to head (e61801b) 74.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   72.99%   74.32%   +1.32%     
==========================================
  Files          19       20       +1     
  Lines        1248     1293      +45     
==========================================
+ Hits          911      961      +50     
+ Misses        294      288       -6     
- Partials       43       44       +1     
Files Coverage Δ
cmd/root.go 80.76% <100.00%> (+5.04%) ⬆️
internal/http/main.go 79.54% <100.00%> (ø)
internal/config/config.go 96.09% <66.66%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke merged commit 0d8b01f into main Oct 6, 2023
9 checks passed
@jkroepke jkroepke deleted the tests branch October 6, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore small nits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant