Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test lint #62

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Test lint #62

merged 4 commits into from
Nov 6, 2023

Conversation

jkroepke
Copy link
Owner

@jkroepke jkroepke commented Nov 6, 2023

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

  • fixes #

Special notes for your reviewer

Particularly user-facing changes

Checklist

Complete these before marking the PR as ready to review:

  • DCO signed
  • The PR title has a summary of the changes
  • The PR body has a summary to reflect any significant (and particularly user-facing) changes introduced by this PR

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b9d536c) 77.80% compared to head (cc5b84e) 77.57%.
Report is 13 commits behind head on main.

❗ Current head cc5b84e differs from pull request most recent head fefec6c. Consider uploading reports for the commit fefec6c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   77.80%   77.57%   -0.23%     
==========================================
  Files          20       20              
  Lines        1320     1320              
==========================================
- Hits         1027     1024       -3     
- Misses        242      244       +2     
- Partials       51       52       +1     
Files Coverage Δ
internal/config/config.go 96.19% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke added the chore small nits label Nov 6, 2023
@jkroepke jkroepke enabled auto-merge (squash) November 6, 2023 00:33
@jkroepke jkroepke merged commit c4ebd99 into main Nov 6, 2023
7 of 8 checks passed
@jkroepke jkroepke deleted the test-lint branch November 6, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore small nits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant