-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java 21 #1370
Java 21 #1370
Conversation
Solves #1319 |
There are a few things that aren't really covered:
Is that intentional? |
Thank you. I missed those two things. JPlag works with anonymous classes. There was just a minor error with negative code positions. The order of tokens might be weird, but as this is still just a preview feature I think that is ok. For guards I added a rule to generate an additional IF and IF_END token, the same way it would be done if there was an if in the case body instead. |
languages/java/src/main/java/de/jplag/java/TokenGeneratingTreeScanner.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small thing
languages/java/src/main/java/de/jplag/java/TokenGeneratingTreeScanner.java
Outdated
Show resolved
Hide resolved
-> https://github.com/jplag/JPlag/actions/runs/7057421814/workflow#L54 It seems that you've missed one last line :) |
To update java for java 21 the following things have to be done:
The following new features are relevant to jplag:
Works without changes
Works without changes
Ignore vardefs without name (javac maps "_" to an empty string)
The following changes should not impact jplag: