Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ros2 support #33

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

feat: ros2 support #33

wants to merge 13 commits into from

Conversation

wep21
Copy link

@wep21 wep21 commented Sep 17, 2022 •
edited
Loading

  • ros2 porting for jsk_common_msgs

Daisuke Nishimatsu added 12 commits September 17, 2022 17:35
feat(jsk_comon_msgs): ros2 porting
996a9ca 
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
feat(jsk_footstep_msgs): ros2 porting
524507a 
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
feat(jsk_gui_msgs): ros2 porting
d39a262 
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
feat(jsk_hark_msgs): ros2 porting
0665bcf 
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
feat(speech_recognition_msgs): ros2 porting
b6bfb12 
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
feat(jsk_hark_msgs): ros2 porting
b38e476 
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
feat(posedetection_msgs): ros2 porting
62d17a0 
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
fix xmllint
2078970 
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
rename .h to .hpp
c1513b8 
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
apply uncrustify
517bd23 
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
fix cpplint
af66967 
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
fix cmake
6d97136 
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
@wep21
Copy link
Author

wep21 commented Sep 17, 2022

@k-okada Could you create rolling branch to support ros2 version?

@k-okada
Copy link
Member

k-okada commented Sep 18, 2022

thank you for contribution, please cosndier using master branch for both ros1/ros2
https://discourse.ros.org/t/building-hybrid-ros1-ros2-metapackages/14592
https://github.com/fzi-forschungszentrum-informatik/Lanelet2/tree/master/lanelet2_core
as we did with rosbuild/catkin in 8 years ago jsk-ros-pkg/jsk_common#220

feat: support both ros1 and ros2
ba45aee 
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
@wep21
Copy link
Author

wep21 commented Oct 8, 2022

@k-okada ba45aee enables to build both ros1 and ros2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wep21 @k-okada