Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add workflow name to recent builds #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mathieux51
Copy link

No description provided.

Copy link
Owner

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mathieux51 ! Thanks for this.

👍 to adding go.mod

I just had one question below about repurposing the subcommand.

Could you provide a screenshot or copy/paste the output to show the before/after of this change?

Comment on lines -244 to +245
Name: "recent-builds",
Aliases: []string{"recent"},
Name: "recent",
Aliases: []string{"r"},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we leave the existing subcommand and add a new one for showing recent workflows?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can create a new command for sure.

@mathieux51
Copy link
Author

If I run it on this repo, this is before:

$ circleci-cli recent
TierMobility/aws-auth-operator/254    failed     master               chore(helm): remove deprecated Kubernetes ApiVersions
TierMobility/aws-auth-operator/253    success    master               chore(helm): remove deprecated Kubernetes ApiVersions
TierMobility/aws-auth-operator/252    success    master               chore(helm): remove deprecated Kubernetes ApiVersions
TierMobility/aws-auth-operator/251    success    update-buildtools    update buildtools to v3
TierMobility/aws-auth-operator/250    success    update-buildtools    update buildtools to v3
TierMobility/aws-auth-operator/249    failed     update-buildtools    update buildtools to v3
TierMobility/aws-auth-operator/248    success    update-buildtools    update buildtools to v3
TierMobility/aws-auth-operator/247    success    master               Create codeql-analysis.yml
TierMobility/aws-auth-operator/246    success    master               Create codeql-analysis.yml
TierMobility/aws-auth-operator/245    success    master               Create codeql-analysis.yml
TierMobility/aws-auth-operator/244    success    master               Create codeql-analysis.yml

and this it after:

$ circleci-cli recent
aws-auth-operator/254 deploy-to-stage         failed     master               chore(helm): remove deprecated Kubernetes ApiVersions
aws-auth-operator/253 build-and-push-image    success    master               chore(helm): remove deprecated Kubernetes ApiVersions
aws-auth-operator/252 pytest                  success    master               chore(helm): remove deprecated Kubernetes ApiVersions
aws-auth-operator/251 build-and-push-image    success    update-buildtools    update buildtools to v3
aws-auth-operator/250 pytest                  success    update-buildtools    update buildtools to v3
aws-auth-operator/249 build-and-push-image    failed     update-buildtools    update buildtools to v3
aws-auth-operator/248 pytest                  success    update-buildtools    update buildtools to v3
aws-auth-operator/247 deploy-to-production    success    master               Create codeql-analysis.yml
aws-auth-operator/246 deploy-to-stage         success    master               Create codeql-analysis.yml
aws-auth-operator/245 build-and-push-image    success    master               Create codeql-analysis.yml
aws-auth-operator/244 pytest                  success    master               Create codeql-analysis.yml

The command I'm running most of the time is:

watch --color circleci-cli --color=always recent -b master

which is related to #17.

If you like us to move forward with this we could:

As I wasn't sure you would accept the changes I took a shortcut but I'm happy to contribute back to the project.

@jszwedko
Copy link
Owner

Thanks @mathieux51 !

I agree with your list of separate PRs. Would you want to go that route? Given the before/after you have there, I'm happy to see this stay as an enhancement to recent-builds / recent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants