-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add workflow name to recent builds #19
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mathieux51 ! Thanks for this.
👍 to adding go.mod
I just had one question below about repurposing the subcommand.
Could you provide a screenshot or copy/paste the output to show the before/after of this change?
Name: "recent-builds", | ||
Aliases: []string{"recent"}, | ||
Name: "recent", | ||
Aliases: []string{"r"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we leave the existing subcommand and add a new one for showing recent workflows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can create a new command for sure.
If I run it on this repo, this is before:
and this it after:
The command I'm running most of the time is:
which is related to #17. If you like us to move forward with this we could:
As I wasn't sure you would accept the changes I took a shortcut but I'm happy to contribute back to the project. |
Thanks @mathieux51 ! I agree with your list of separate PRs. Would you want to go that route? Given the before/after you have there, I'm happy to see this stay as an enhancement to |
No description provided.