Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.9.3 #173

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Version 1.9.3 #173

merged 1 commit into from
Nov 21, 2023

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Nov 21, 2023

Waiting for #171

@IanButterworth IanButterworth requested a review from a team as a code owner November 21, 2023 14:59
@IanButterworth IanButterworth marked this pull request as draft November 21, 2023 15:24
@IanButterworth IanButterworth marked this pull request as ready for review November 21, 2023 16:09
@IanButterworth IanButterworth merged commit a86c40a into master Nov 21, 2023
43 checks passed
@IanButterworth IanButterworth deleted the ib/1_9_3 branch November 21, 2023 16:12
@IanButterworth
Copy link
Member Author

IanButterworth commented Nov 21, 2023

@SaschaMann I created a new release https://github.com/julia-actions/setup-julia/releases/tag/v1.9.3

Which appears to be live https://github.com/marketplace/actions/setup-julia-environment

But v1 is resolving v1.9.2 still here (f40c4b6 is v1.9.2)

Download action repository 'julia-actions/setup-julia@v1' (SHA:f40c4b69330df1d22e7590c12e76dc2f9c66e0bc)

However, if I set v1.9.3 explicitly I see a concerning error here

Run julia-actions/setup-julia@v1.9.3
  with:
    version: 1
    include-all-prereleases: false
    arch: X64
    show-versioninfo: false
Error: File not found: '/home/runner/work/_actions/julia-actions/setup-julia/v1.9.3/dist/index.js'

@IanButterworth
Copy link
Member Author

IanButterworth commented Nov 21, 2023

Fixed. I released a fixed 1.9.4.
Sorry about that. I didn't look hard-enough to find the release scripts in bin (they also don't work on MacOS for me)

No one should've seen the broken release because it would've required them to use @v1.9.3 specifically

@SaschaMann
Copy link
Member

SaschaMann commented Nov 21, 2023

Sorry about that. I didn't look hard-enough to find the release scripts in bin (they also don't work on MacOS for me)

You can't know that, I don't think it's documented anywhere and doesn't match any of the other Julia actions anymore, sorry!

Do you know what's broken on macOS? Maybe we can easily fix it to make it OS-independent (I assumed it already was).

Shellcheck warns me about this:

$ shellcheck myscript
 
[Line 38:](javascript:setPosition(38, 35))
major_minor="$(sed 's/\.[^.]*$//' <<< "$version")"
                                  ^-- [SC3011](https://www.shellcheck.net/wiki/SC3011) (warning): In POSIX sh, here-strings are undefined.
 
[Line 39:](javascript:setPosition(39, 29))
major="$(sed 's/\.[^.]*$//' <<< "$major_minor")"
                            ^-- [SC3011](https://www.shellcheck.net/wiki/SC3011) (warning): In POSIX sh, here-strings are undefined.

Is that the error you were seeing as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants