Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fish] Optimize history formatting without perl #4171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bitraid
Copy link
Contributor

@bitraid bitraid commented Jan 11, 2025

The previous bug fix made the operation 2x slower. With this change, it becomes almost as fast as before.

I have another change I've been testing locally, which begins to display the results instantly (but it's a bigger change and it depends on this code, so it's better to be in another PR). Currently, because the fzf command is being constructed using eval, it becomes blocking (fish blocks when executing builtins). Consider for example:

for i in (seq 5); echo $i; sleep 1; end | eval (echo fzf)

Versus:

for i in (seq 5); echo $i; sleep 1; end | fzf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant