-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added samsung pay #112
base: main
Are you sure you want to change the base?
Conversation
| (_, _, SamsungPay.Not_Started) => <SdkLoadingScreen /> | ||
| (_, None, _) | ||
| (Loading, _, _) => | ||
nativeProp.hyperParams.defaultView && samsungPayValidity->SamsungPay.isSamsungPayValid | ||
? <PaymentSheet setConfirmButtonDataRef /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move this to PMListModifier.res as checks for other wallets are also handled there
protocol: string, | ||
allowed_brands: array<JSON.t>, | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we getting a new object from backend for samsung pay or we can merge with sessions types?
As @AashuJuspay has all session objects in one type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of current implementation, we have a single session type for session tokens of google pay and apply pay, so added some samsung pay specific fields here
recurring_payment: bool, | ||
// payment_shipping_address: paymentShippingAddress, | ||
// payment_shipping_method: string, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we handle billing address requirements for a processor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not collecting it via Samsung Pay, as it will add extra friction of filling all these details in Samsung Pay Sheet. We will either accept that in create or confirm ( via HS SDK)
3988dd0
to
3230e5e
Compare
afd0bff
to
f4d0ef3
Compare
Added Samsung Pay
TO DO: