Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added samsung pay #112

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: added samsung pay #112

wants to merge 11 commits into from

Conversation

Sanskar2001
Copy link
Contributor

@Sanskar2001 Sanskar2001 commented Oct 3, 2024

Added Samsung Pay
TO DO:

  • Adding logs for Samsung Pay
  • Confirm payload needs to be changed [DONE]

| (_, _, SamsungPay.Not_Started) => <SdkLoadingScreen />
| (_, None, _)
| (Loading, _, _) =>
nativeProp.hyperParams.defaultView && samsungPayValidity->SamsungPay.isSamsungPayValid
? <PaymentSheet setConfirmButtonDataRef />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move this to PMListModifier.res as checks for other wallets are also handled there

protocol: string,
allowed_brands: array<JSON.t>,
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we getting a new object from backend for samsung pay or we can merge with sessions types?
As @AashuJuspay has all session objects in one type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of current implementation, we have a single session type for session tokens of google pay and apply pay, so added some samsung pay specific fields here

recurring_payment: bool,
// payment_shipping_address: paymentShippingAddress,
// payment_shipping_method: string,
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we handle billing address requirements for a processor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not collecting it via Samsung Pay, as it will add extra friction of filling all these details in Samsung Pay Sheet. We will either accept that in create or confirm ( via HS SDK)

@25harsh 25harsh force-pushed the main branch 2 times, most recently from 3988dd0 to 3230e5e Compare November 20, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants