chore: dynamic webhook auth headers #1069
Open
+294
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeevaRamu0104
added
chore
gitanjli525
reviewed
Jul 25, 2024
| } | ||
| <div className="flex-1"> | ||
| <p | ||
| className={`ml-4 text-fs-13 text-jp-gray-900 dark:text-jp-gray-text_darktheme dark:text-opacity-50 ml-1 !text-base !text-grey-700 font-semibold ml-1`}> |
There was a problem hiding this comment.
ml-x text-{color} is repeated property here, can you please remove that is not required?
gitanjli525
reviewed
Jul 25, 2024
| ->Array.mapWithIndex((_, index) => | ||
| <div key={index->Int.toString} className="col-span-4"> | ||
| <AuthenticationInput index={index} /> | ||
| <div key={index->Int.toString} className="grid grid-cols-5 flex gap-4"> |
There was a problem hiding this comment.
className="grid grid-cols-5 gap-4"
gitanjli525
previously approved these changes
Jul 25, 2024
Comment on lines
+82
to
+85
| switch value->getOptionIntFromString->Option.isNone { | ||
| | true => setKey(_ => value) | ||
| | _ => () | ||
| } |
There was a problem hiding this comment.
Suggested change
| switch value->getOptionIntFromString->Option.isNone { | |
| | true => setKey(_ => value) | |
| | _ => () | |
| } | |
| if (value->getOptionIntFromString->Option.isNone) { | |
| setKey(_ => value) | |
| } |
| }, | ||
| onChange: ev => { | ||
| let value = ReactEvent.Form.target(ev)["value"] | ||
| if value->String.length <= 0 { |
There was a problem hiding this comment.
=== 0 LogiicUtils isEmptyString
| onBlur: _ => (), | ||
| onChange: ev => { | ||
| let value = ReactEvent.Form.target(ev)["value"] | ||
| if key->String.length > 0 { |
| ->getDictfromDict("outgoing_webhook_custom_http_headers") | ||
| ->Dict.toArray | ||
| ->Array.filter(((key, value)) => | ||
| key->String.length != 0 && value->getStringFromJson("")->String.length != 0 |
JeevaRamu0104
dismissed
gitanjli525’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Currently by default all the four input boxes are shown instead of that allow user to add the input boxes
Motivation and Context
How did you test it?
Checklist
npm run re:build