Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new pill input type #1901

Merged
merged 7 commits into from
Dec 12, 2024
Merged

feat: new pill input type #1901

merged 7 commits into from
Dec 12, 2024

Conversation

kanikabansal-juspay
Copy link
Collaborator

@kanikabansal-juspay kanikabansal-juspay commented Dec 11, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Addition of a new input type which takes multiple input values convert them to array of pills.

Screen.Recording.2024-12-12.at.11.24.59.AM.mov

Motivation and Context

Requirement in other task and provides a more intuitive way to display and manage multiple values in the UI.

How did you test it?

Locally.

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@kanikabansal-juspay kanikabansal-juspay added the C-feature Category: Feature request or enhancement label Dec 11, 2024
@kanikabansal-juspay kanikabansal-juspay self-assigned this Dec 11, 2024
@kanikabansal-juspay kanikabansal-juspay requested a review from a team as a code owner December 11, 2024 10:33
Copy link

Review changes with  SemanticDiff

Copy link
Contributor

@PritishBudhiraja PritishBudhiraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a video how it will look. Rest looks fine

src/components/form/PillInput.res Outdated Show resolved Hide resolved
src/components/form/PillInput.res Outdated Show resolved Hide resolved
src/components/form/PillInput.res Outdated Show resolved Hide resolved
src/components/form/PillInput.res Outdated Show resolved Hide resolved
src/components/form/PillInput.res Outdated Show resolved Hide resolved
src/components/form/PillInput.res Outdated Show resolved Hide resolved
src/components/form/PillInput.res Outdated Show resolved Hide resolved
src/components/form/PillInput.res Show resolved Hide resolved
src/components/form/PillInput.res Outdated Show resolved Hide resolved
src/components/form/PillInput.res Outdated Show resolved Hide resolved
src/components/form/PillInput.res Show resolved Hide resolved
Copy link
Contributor

@PritishBudhiraja PritishBudhiraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kanikabansal-juspay kanikabansal-juspay added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 9c4c673 Dec 12, 2024
5 of 6 checks passed
@kanikabansal-juspay kanikabansal-juspay deleted the input-pill branch December 12, 2024 08:56
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed C-feature Category: Feature request or enhancement labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Generic Pill Input type for addition of multiple emails
3 participants