Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Additional recipients in generate report #1911

Merged
merged 8 commits into from
Dec 16, 2024
Merged

feat: Additional recipients in generate report #1911

merged 8 commits into from
Dec 16, 2024

Conversation

kanikabansal-juspay
Copy link
Collaborator

@kanikabansal-juspay kanikabansal-juspay commented Dec 12, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Addition of multiple email field in the generate report payment operations.
  • Report type ( view ) information displayed in the modal box/
  • Rendering bug in Pill Input . Earlier on clicking for editing one email makes other emails disappear because of selective rendering.
Screen.Recording.2024-12-12.at.5.25.17.PM.mov

Motivation and Context

Feature request.

How did you test it?

Attached Video.

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@kanikabansal-juspay kanikabansal-juspay requested a review from a team as a code owner December 12, 2024 11:59
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@kanikabansal-juspay kanikabansal-juspay self-assigned this Dec 12, 2024
@kanikabansal-juspay kanikabansal-juspay added the C-feature Category: Feature request or enhancement label Dec 12, 2024
@kanikabansal-juspay kanikabansal-juspay linked an issue Dec 12, 2024 that may be closed by this pull request
[FEATURE] List of additional email recipient in generate report payment ops #1912
Closed
JeevaRamu0104
JeevaRamu0104 previously approved these changes Dec 16, 2024
View reviewed changes
JeevaRamu0104
JeevaRamu0104 previously approved these changes Dec 16, 2024
View reviewed changes
Riddhiagrawal001
Riddhiagrawal001 previously approved these changes Dec 16, 2024
View reviewed changes
src/components/form/PillInput.res Show resolved Hide resolved
src/components/form/PillInput.res Show resolved Hide resolved
@kanikabansal-juspay kanikabansal-juspay added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit 73478b5 Dec 16, 2024
5 of 6 checks passed
@kanikabansal-juspay kanikabansal-juspay deleted the generate-reports branch December 16, 2024 12:57
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed C-feature Category: Feature request or enhancement labels Dec 16, 2024
@kanikabansal-juspay kanikabansal-juspay linked an issue Dec 27, 2024 that may be closed by this pull request
[UI] Add OMP selection in reports #1806
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagarnaikjuspay sagarnaikjuspay sagarnaikjuspay approved these changes

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

@Riddhiagrawal001 Riddhiagrawal001 Awaiting requested review from Riddhiagrawal001

Assignees

@kanikabansal-juspay kanikabansal-juspay

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
4 participants
@kanikabansal-juspay @Riddhiagrawal001 @JeevaRamu0104 @sagarnaikjuspay