Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: invite users enhancement #1964

Merged
merged 4 commits into from
Jan 2, 2025
Merged

chore: invite users enhancement #1964

merged 4 commits into from
Jan 2, 2025

Conversation

gitanjli525
Copy link
Contributor

@gitanjli525 gitanjli525 commented Dec 23, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • showing loader modal while switch merchant and profile in invite users
  • displaying "All Profiles" by default in profile dropdown to indicate merchant level user being invited
Screen.Recording.2024-12-27.at.2.49.56.PM.mov

Motivation and Context

How did you test it?

  • changes visible in invite users page

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@gitanjli525 gitanjli525 self-assigned this Dec 23, 2024
@gitanjli525 gitanjli525 requested a review from a team as a code owner December 23, 2024 10:07
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@gitanjli525 gitanjli525 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed core Status: issues related to core labels Dec 23, 2024
@gitanjli525 gitanjli525 linked an issue Dec 23, 2024 that may be closed by this pull request
[CHORE]: invite user changes #1965
Closed
JeevaRamu0104
JeevaRamu0104 reviewed Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@JeevaRamu0104 JeevaRamu0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attach some screen shot or video of how it works

src/screens/UserManagement/UserRevamp/InviteMember.res Outdated Show resolved Hide resolved
@prajwalnl0 prajwalnl0 added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit b47d5f5 Jan 2, 2025
8 of 9 checks passed
@prajwalnl0 prajwalnl0 deleted the invite-users-enhancement branch January 2, 2025 05:35
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed core Status: issues related to core labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanikabansal-juspay kanikabansal-juspay kanikabansal-juspay approved these changes

@sagarnaikjuspay sagarnaikjuspay sagarnaikjuspay approved these changes

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

Assignees

@gitanjli525 gitanjli525

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CHORE]: invite user changes
5 participants
@gitanjli525 @JeevaRamu0104 @sagarnaikjuspay @kanikabansal-juspay @prajwalnl0