Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(payments): add card_holder_name to request only if the value is present #832

Merged
merged 2 commits into from
Dec 11, 2024
Merged

refactor(payments): add card_holder_name to request only if the value is present #832

merged 2 commits into from
Dec 11, 2024

Conversation

kashif-m
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR has changes for adding card_holder_name in the request body only the value is present.

How did you test it?

Locally using payment links
Screenshot 2024-12-11 at 2 01 04 PM

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@kashif-m kashif-m self-assigned this Dec 11, 2024
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@PritishBudhiraja PritishBudhiraja added the Ready for Review PR with label Ready for Review should only be reviewed. label Dec 11, 2024
@PritishBudhiraja PritishBudhiraja merged commit 769f845 into main Dec 11, 2024
4 checks passed
@PritishBudhiraja PritishBudhiraja deleted the 831-add-card-holder-name branch December 11, 2024 08:56
@github-actions github-actions bot added Closed Label will be automatically added when the PR will get merged to main and removed Ready for Review PR with label Ready for Review should only be reviewed. labels Dec 11, 2024
@kashif-m kashif-m linked an issue Dec 11, 2024 that may be closed by this pull request
[REFACTOR] do not send empty string as values in API requests #831
Closed
kashif-m added a commit that referenced this pull request Dec 12, 2024
@kashif-m
refactor(payments): add card_holder_name to request only if the value…
9fb0083 
… is present (#832)

Co-authored-by: Pritish Budhiraja <pritish.budhiraja@gmail.com>
(cherry picked from commit 769f845)
@kashif-m kashif-m mentioned this pull request Dec 12, 2024
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

@seekshiva seekshiva Awaiting requested review from seekshiva seekshiva is a code owner

@ArushKapoorJuspay ArushKapoorJuspay Awaiting requested review from ArushKapoorJuspay ArushKapoorJuspay is a code owner

Assignees

@kashif-m kashif-m

Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] do not send empty string as values in API requests
2 participants
@kashif-m @PritishBudhiraja