Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for ClickToPay #846

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ArushKapoorJuspay
Copy link
Contributor

@ArushKapoorJuspay ArushKapoorJuspay commented Dec 18, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added support for ClickToPay - Doc Link

How did you test it?

Tested Basic ClickToPay flows which are supported by Mastercard - Test Case Sheet

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

Copy link

semanticdiff-com bot commented Dec 18, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  package-lock.json  0% smaller
  package.json  0% smaller
  public/icons/orca.svg Unsupported file format
  src/App.res Unsupported file format
  src/Components/ClickToPayAuthenticate.res Unsupported file format
  src/Components/ClickToPayDetails.res Unsupported file format
  src/Components/ClickToPayLearnMore.res Unsupported file format
  src/Components/ClickToPayNotYou.res Unsupported file format
  src/Components/DynamicFields.res Unsupported file format
  src/Components/SaveDetailsCheckbox.res Unsupported file format
  src/Components/SavedMethods.res Unsupported file format
  src/Hooks/CommonHooks.res Unsupported file format
  src/PaymentElement.res Unsupported file format
  src/Payments/CardPayment.res Unsupported file format
  src/Types/ClickToPayHelpers.res Unsupported file format
  src/Types/PaymentType.res Unsupported file format
  src/Types/SessionsType.res Unsupported file format
  src/Utilities/DynamicFieldsUtils.res Unsupported file format
  src/Utilities/PaymentBody.res Unsupported file format
  src/Utilities/RecoilAtoms.res Unsupported file format
  src/Window.res Unsupported file format
  src/hyper-loader/LoaderPaymentElement.res Unsupported file format
  src/hyper-log-catcher/HyperLogger.res Unsupported file format

src/hyper-loader/Elements.res Outdated Show resolved Hide resolved
src/Utilities/RecoilAtoms.res Outdated Show resolved Hide resolved
src/Utilities/PaymentBody.res Show resolved Hide resolved
src/Utilities/DynamicFieldsUtils.res Outdated Show resolved Hide resolved
src/Types/ClickToPayHelpers.res Show resolved Hide resolved
src/Types/ClickToPayHelpers.res Show resolved Hide resolved
src/Types/ClickToPayHelpers.res Show resolved Hide resolved
src/Types/ClickToPayHelpers.res Outdated Show resolved Hide resolved
// Cookie helpers
@val external document: {..} = "document"

let setLocalStorage = (~key: string, ~value: string) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @seekshiva, for ClickToPay should we store the recognitionToken in the cookies or in localStorage? Both scenarios will work in Chrome browser however cause issue in Safari

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what works in safari?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Review PR with label Ready for Review should only be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants