ci(workflows): Add code coverage reporting for v2 #6884
+782
−172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
AnuthaDev
force-pushed
the
code-vyapti
branch
from
8e2283a to
d91b994
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
AnuthaDev
force-pushed
the
code-vyapti
branch
5 times, most recently
from
d2a1842 to
4873fa2
Compare
pixincreate
reviewed
Dec 26, 2024
AnuthaDev
force-pushed
the
code-vyapti
branch
from
c9cde82 to
e74b921
Compare
AnuthaDev
force-pushed
the
code-vyapti
branch
from
e74b921 to
a9ec871
Compare
Comment on lines
+432
to
+433
| run: | | ||
| scripts/execute_cypress.sh "" "" "cypress-tests-v2" |
There was a problem hiding this comment.
Nit:
Suggested change
| run: | | |
| scripts/execute_cypress.sh "" "" "cypress-tests-v2" | |
| run: scripts/execute_cypress.sh "" "" "cypress-tests-v2" |
Can also add a comment clarifying why the first 2 args are empty. It's not evident unless someone checks the source of the script file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added a CI pipeline that will run cypress tests and generate code coverage reports for v2
Additional Changes
Motivation and Context
Closes #1593
Closes #1587
Closes #1622
Closes #1700
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy