Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(connector): Move connectors Mifinity, Iatapay, Itaubank, Globalpay, Klarna from router to hyperswitch_connectors crate #6922

Open
wants to merge 8 commits into
base: connector-crate-move
Choose a base branch
from

Conversation

spritianeja03
Copy link
Contributor

@spritianeja03 spritianeja03 commented Dec 23, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Move Mifinity, Iatapay, Itaubank, Globalpay and Klarna from router crate to hyperswitch_connector crate

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@spritianeja03 spritianeja03 self-assigned this Dec 23, 2024
Copy link

semanticdiff-com bot commented Dec 23, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  crates/hyperswitch_connectors/src/connectors/iatapay/transformers.rs  82% smaller
  crates/hyperswitch_connectors/src/connectors/bankofamerica/transformers.rs  76% smaller
  crates/router/src/connector.rs  76% smaller
  crates/hyperswitch_connectors/src/connectors/wellsfargo/transformers.rs  70% smaller
  crates/hyperswitch_connectors/src/connectors/klarna/transformers.rs  69% smaller
  crates/hyperswitch_connectors/src/connectors/itaubank/transformers.rs  65% smaller
  crates/hyperswitch_connectors/src/connectors/cybersource/transformers.rs  64% smaller
  crates/hyperswitch_connectors/src/connectors/bankofamerica.rs  59% smaller
  crates/hyperswitch_connectors/src/connectors/globalpay/transformers.rs  57% smaller
  crates/hyperswitch_connectors/src/connectors/globalpay.rs  57% smaller
  crates/hyperswitch_connectors/src/connectors/cybersource.rs  55% smaller
  crates/hyperswitch_connectors/src/connectors/wellsfargo.rs  54% smaller
  crates/hyperswitch_connectors/src/connectors.rs  54% smaller
  crates/hyperswitch_connectors/src/connectors/klarna.rs  52% smaller
  crates/hyperswitch_connectors/src/connectors/itaubank.rs  50% smaller
  crates/hyperswitch_connectors/src/connectors/iatapay.rs  49% smaller
  crates/hyperswitch_connectors/src/connectors/mifinity.rs  47% smaller
  crates/hyperswitch_connectors/src/connectors/mifinity/transformers.rs  44% smaller
  crates/hyperswitch_domain_models/src/types.rs  43% smaller
  crates/hyperswitch_connectors/src/default_implementations_v2.rs  13% smaller
  crates/hyperswitch_connectors/src/default_implementations.rs  13% smaller
  crates/router/src/core/payments/flows.rs  9% smaller
  crates/hyperswitch_connectors/src/types.rs  8% smaller
  crates/router/src/core/payments/connector_integration_v2_impls.rs  8% smaller
  crates/hyperswitch_connectors/src/utils.rs  3% smaller
  Cargo.lock Unsupported file format
  crates/common_utils/src/consts.rs  0% smaller
  crates/hyperswitch_connectors/Cargo.toml Unsupported file format
  crates/hyperswitch_connectors/src/connectors/globalpay/requests.rs  0% smaller
  crates/hyperswitch_connectors/src/connectors/globalpay/response.rs  0% smaller
  crates/hyperswitch_connectors/src/constants.rs  0% smaller
  crates/router/src/consts.rs  0% smaller

@spritianeja03 spritianeja03 added A-connector-integration Area: Connector integration C-refactor Category: Refactor labels Dec 23, 2024
@spritianeja03 spritianeja03 changed the title refactor: [MIFINITY, GPAYMENTS, IATAPAY, ITAUBANK, GLOBALPAY, KLARNA] move code to hyperswitch_connectors crate refactor(connector): Move connectors Mifinity, Iatapay, Itaubank, Gpayments, Globalpay, Klarna from router to hyperswitch_connectors crate Dec 26, 2024
@spritianeja03 spritianeja03 added this to the December 2024 Release milestone Dec 26, 2024
@spritianeja03 spritianeja03 changed the base branch from main to connector-crate-move December 27, 2024 09:54
@spritianeja03 spritianeja03 marked this pull request as ready for review December 27, 2024 09:56
@spritianeja03 spritianeja03 requested review from a team as code owners December 27, 2024 09:56
@spritianeja03 spritianeja03 changed the title refactor(connector): Move connectors Mifinity, Iatapay, Itaubank, Gpayments, Globalpay, Klarna from router to hyperswitch_connectors crate refactor(connector): Move connectors Mifinity, Iatapay, Itaubank, Globalpay, Klarna from router to hyperswitch_connectors crate Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants