Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop "multiarch manifest problem" mention from airgap doc #3607

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Drop "multiarch manifest problem" mention from airgap doc #3607

merged 1 commit into from
Oct 19, 2023

Conversation

kke
Copy link
Contributor

@kke kke commented Oct 19, 2023

Description

The linked issue was closed long ago and k0s embeds kube-proxy now.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@kke kke added the documentation Improvements or additions to documentation label Oct 19, 2023
@kke kke requested a review from a team as a code owner October 19, 2023 08:30
@kke kke requested review from ncopa and juanluisvaladas October 19, 2023 08:30
@kke kke changed the title Drop outdated "multiarch manifest problem" mention from airgap doc Drop "multiarch manifest problem" mention from airgap doc Oct 19, 2023
@kke
Remove "multiarch manifest problem" mention from airgap doc
4db313b 
Linked issue was closed long ago and k0s ships with kube-proxy now.

Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke kke force-pushed the docs-manifest-problem branch from 0676ce9 to 4db313b Compare October 19, 2023 08:32
@twz123 twz123 added the backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch label Oct 19, 2023
@kke kke merged commit 4269ebd into main Oct 19, 2023
6 checks passed
@kke kke deleted the docs-manifest-problem branch October 19, 2023 08:38
@k0s-bot k0s-bot mentioned this pull request Oct 19, 2023
Merged
@k0s-bot
Copy link

k0s-bot commented Oct 19, 2023

Successfully created backport PR for release-1.28:

This was referenced Oct 19, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twz123 twz123 twz123 approved these changes

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

@juanluisvaladas juanluisvaladas Awaiting requested review from juanluisvaladas juanluisvaladas is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kke @k0s-bot @twz123