[Backport release-1.28] Fix "executable in PATH" sysprobe #3643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The loop over the varargs was not capturing the loop variable correctly, so all the probes would check the same binary. Remove the loop and let callers call the function multiple times for each executable. This is less error prone. That bug was first introduced in 0f474b8, but didn't become effective before 0f474b8. Fixes: 0f474b8 ("Some new sysinfo probes") Fixes: 19c800d ("Add sysprobe and some docs for required mount/umount") Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com> (cherry picked from commit c2d5e87)
16 tasks
ncopa
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated backport to
release-1.28, triggered by a label in #3641.See #1784 #3409.