Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base64-decode cosign key in release workflow #3976

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jan 24, 2024

Description

The cosign key is stored in base64-encoded form. This way it cannot be directly consumed by cosign.

Fixes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

The cosign key is stored in base64-encoded form. This way it cannot be
directly consumed by cosign.

Fixes: 192d291 ("Use downloaded cosign binary in release workflow")
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 requested a review from a team as a code owner January 24, 2024 14:46
@twz123 twz123 requested review from kke and juanluisvaladas January 24, 2024 14:46
@twz123 twz123 enabled auto-merge January 24, 2024 16:59
@twz123 twz123 merged commit c2d81b6 into k0sproject:main Jan 25, 2024
73 checks passed
@twz123 twz123 deleted the base64-decode-cosign-key branch January 25, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants