Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Plan id and timestamp fields optional #4059

Closed
wants to merge 1 commit into from
Closed

Make Plan id and timestamp fields optional #4059

wants to merge 1 commit into from

Conversation

nekwar
Copy link
Contributor

@nekwar nekwar commented Feb 15, 2024

Description

Fixes #4058

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

k0s cluster was created with newly built binary, Plan without spec.id and spec.timestamp was created:

kind: Plan
metadata:
  name: autopilot
spec:
  commands:
    - k0supdate:
        version: v1.29.1+k0s.1
        platforms:
          linux-amd64:
            url: https://github.com/k0sproject/k0s/releases/download/v1.29.1+k0s.1/k0s-v1.29.1+k0s.1-amd64
        targets:
          controllers:
            discovery:
              selector:
                labels: app=123

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Signed-off-by: Roman Kuzmin <romanrawken@gmail.com>
@nekwar nekwar requested a review from a team as a code owner February 15, 2024 10:14
@juanluisvaladas
Copy link
Contributor

@jnummelin you're way more familiar than me with autopilot, would you mind having a look? I believe this is fine and we only have those fields so that they are filled when UpdateConfig creates the plan but I'm not too sure.

Copy link
Contributor

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added Stale and removed Stale labels Mar 16, 2024
Copy link
Contributor

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Apr 16, 2024
@github-actions github-actions bot closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autopilot's Plan optional fields are not actually optional (spec.id, spec.timestamp)
2 participants