Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in sysinfo CONFIG_NF_CONNTRACK_IPV4/IPV6 description #5395

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix typo in sysinfo CONFIG_NF_CONNTRACK_IPV4/IPV6 description #5395

wants to merge 3 commits into from

Conversation

tmalaher
Copy link

@tmalaher tmalaher commented Jan 1, 2025

Description

Fix typo in sysinfo CONFIG_NF_CONNTRACK_IPV4/IPV6 description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Documentation and user-interface string update. No testing required.

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@tmalaher
Fix typo in host_linux.go
f3d32c2 
s/connetion/connection/

Signed-off-by: Tom Malaher <tmalaher@netstart.com>
@tmalaher @tmalaher-telus
Fix typo in raspberry-pi4.md
b524e28 
s/connetion/connection/ to match internal/pkg/sysinfo/host_linux.go

Signed-off-by: Tom Malaher <tmalaher@netstart.com>
@tmalaher tmalaher requested review from a team as code owners January 1, 2025 17:11
@tmalaher tmalaher requested review from ncopa and jnummelin January 1, 2025 17:11
juanluisvaladas
juanluisvaladas requested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@juanluisvaladas juanluisvaladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, according to the linter the host_linux.go file need to be rewritten by go fmt. Once that's fixed we can merge it.

@tmalaher
Align comments in host_linux.go
9f5ed78 
...to match change in previous line.

Signed-off-by: Tom Malaher <tmalaher@netstart.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanluisvaladas juanluisvaladas juanluisvaladas requested changes

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

@jnummelin jnummelin Awaiting requested review from jnummelin jnummelin is a code owner automatically assigned from k0sproject/k0s-maintainers

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmalaher @juanluisvaladas