Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:requireViewpoints #517

Merged
merged 1 commit into from
Oct 7, 2023
Merged

feat:requireViewpoints #517

merged 1 commit into from
Oct 7, 2023

Conversation

majimaccho
Copy link
Contributor

@majimaccho majimaccho commented Oct 7, 2023 •
edited
Loading

Description

Fixes #516

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Added unit test codes, based on existing test codes.
  • Tested locally with my codebase with a table (https://github.com/macoto1995/redwood-graphile-worker)
    • set requireViewpoints enabled and checked
      • lint passed when viewpoints are set
      • throws an error when no viewpoint was set

@k1LoW k1LoW added enhancement New feature or request minor labels Oct 7, 2023
@k1LoW
Copy link
Owner

k1LoW commented Oct 7, 2023

@macoto1995 GREAT WORK!!!!!!! Thank you!!!!

@k1LoW k1LoW merged commit f4d5aaa into k1LoW:main Oct 7, 2023
2 checks passed
@github-actions github-actions bot mentioned this pull request Oct 7, 2023
Merged
@Porkepix Porkepix mentioned this pull request Oct 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint rule "requireViewpoints"
2 participants
@majimaccho @k1LoW