Skip to content

Fix linter errors

Fix linter errors #56

Triggered via pull request March 28, 2024 22:15
Status Failure
Total duration 22s
Artifacts

go.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 6 warnings
Lint: kaitai/stream_test.go#L760
760-787 lines are duplicate of `kaitai/stream_test.go:789-816` (dupl)
Lint: kaitai/stream_test.go#L789
789-816 lines are duplicate of `kaitai/stream_test.go:760-787` (dupl)
Lint: kaitai/error.go#L65
line is 127 characters (lll)
Lint: kaitai/error.go#L96
line is 122 characters (lll)
Lint: kaitai/error.go#L127
line is 128 characters (lll)
Lint: kaitai/stream.go#L45
comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
Lint: kaitai/stream.go#L259
comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
Lint: kaitai/stream.go#L211
err113: do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf(\"ReadBytes(%d): negative number of bytes to read\", n)" (goerr113)
Lint: kaitai/stream.go#L313
err113: do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf(\"ReadBitsIntBe(%d): more than 8 bytes requested\", n)" (goerr113)
Lint: kaitai/stream.go#L354
err113: do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf(\"ReadBitsIntLe(%d): more than 8 bytes requested\", n)" (goerr113)
Lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Lint: kaitai/stream.go#L276
unused-parameter: parameter 'encoding' seems to be unused, consider removing or renaming it as _ (revive)
Lint: kaitai/stream.go#L287
unused-parameter: parameter 'encoding' seems to be unused, consider removing or renaming it as _ (revive)
Lint: kaitai/stream.go#L380
unused-parameter: parameter 'n' seems to be unused, consider removing or renaming it as _ (revive)
Test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-go@v2, actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/