Skip to content

Commit

Permalink
update dependencies
Browse files Browse the repository at this point in the history 
commander 2.16.0
  • Loading branch information
@alexlamsl
alexlamsl committed Jun 30, 2018
1 parent fd8bc0f commit 68c978c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 0 additions & 2 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
[![NPM version](https://img.shields.io/npm/v/html-minifier.svg)](https://www.npmjs.com/package/html-minifier)
[![Build Status](https://img.shields.io/travis/kangax/html-minifier.svg)](https://travis-ci.org/kangax/html-minifier)
[![Dependency Status](https://img.shields.io/david/kangax/html-minifier.svg)](https://david-dm.org/kangax/html-minifier)
[![devDependency Status](https://img.shields.io/david/dev/kangax/html-minifier.svg)](https://david-dm.org/kangax/html-minifier?type=dev)

This comment has been minimized.

Sign in to view

Copy link
@XhmikosR

XhmikosR Jul 8, 2018

Collaborator

@alexlamsl: why did you remove the devDependencies badge?

This comment has been minimized.

Sign in to view

Copy link
@alexlamsl

alexlamsl Jul 8, 2018

Author Collaborator

eslint no longer supports the range of Node.js platforms that we do, rendering that particular badge meaningless.

This comment has been minimized.

Sign in to view

Copy link
@XhmikosR

XhmikosR Jul 8, 2018

Collaborator

Not really, no. The badge refers to all devDependencies.

This comment has been minimized.

Sign in to view

Copy link
@alexlamsl

alexlamsl Jul 8, 2018

Author Collaborator

How am I going to tell if any other devDependencies are out of date if it is constantly stuck in state?

This comment has been minimized.

Sign in to view

Copy link
@XhmikosR

XhmikosR Jul 8, 2018

Collaborator

The badge changes colors depending on some factors.

Also, IMO

  1. we should switch back to grunt-eslint
  2. drop node.js 4.x and ES6-ify the code base along with a major version bump

We should not endorse obsolete Node.js versions.

This comment has been minimized.

Sign in to view

Copy link
@alexlamsl

alexlamsl Jul 8, 2018

Author Collaborator

The badge changes colors depending on some factors.

If you have a way to turn it green without using an incompatible version of eslint, I'm all ears.

drop node.js 4.x and ES6-ify the code base along with a major version bump

I'm actively using JavaScript in my line of work, so any ES6 will be getting in the way of backward compatibility.

We should not endorse obsolete Node.js versions.

I don't work for Node.js - just because someone declares their product obsolete does not mean others aren't using a verified & reliable option.
[![Gitter](https://img.shields.io/gitter/room/kangax/html-minifier.svg)](https://gitter.im/kangax/html-minifier)

[HTMLMinifier](http://kangax.github.io/html-minifier/) is a highly **configurable**, **well-tested**, JavaScript-based HTML minifier.

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"dependencies": {
"camel-case": "3.0.x",
"clean-css": "4.1.x",
"commander": "2.15.x",
"commander": "2.16.x",
"he": "1.1.x",
"param-case": "2.1.x",
"relateurl": "0.2.x",
Expand Down

0 comments on commit 68c978c

Please sign in to comment.