-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor #1
Open
JoseAlbDR
wants to merge
73
commits into
kasappeal:main
Choose a base branch
from
JoseAlbDR:refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix message for console.log (server running url)
…loop ignoring json files with nodemon.json config file
…or to old version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code refactor into diferent folders for better scalability and clean code:
Refactor all config variables from index.js to config folder.
Refactor all controllers logic from index.js to controllers folder.
Refactor all database logic from index.js to database folder.
Refactor all middlewares from index.js to middlewares folder.
Refactor all routes logic from index.js to routes folder
Refactor al utils from index.js to utils folder.
New features/improvements:
Create new folder structure for file uploads now is public/uploads/{username}/{filename}
Create new endpoint /users/me that returns user related data (id, username)
Create new notFoundMiddleware that returns an error message if the request route does not exist
Update logs with succesfully DB and server connection messages
Update Readme file
Upate al dependencies and devDependencies to latest versions
Add swagger documentation
Add postman collection file
Fixes:
Fix nodemon infinite loop while running dev script (npm run dev)