Skip to content

Commit

Permalink
perf(web-rig): all web riggable packages will produces esm by default
Browse files Browse the repository at this point in the history
  • Loading branch information
kamontat committed Dec 18, 2023
1 parent 014b3bb commit d675f1c
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 14 deletions.
6 changes: 3 additions & 3 deletions packages/web-rig/profiles/default/config/jest.config.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"extends": "@rushstack/heft-jest-plugin/includes/jest-shared.config.json",
"testEnvironment": "jsdom",
"extends": "@rushstack/heft-jest-plugin/includes/jest-web.config.json",
"reporters": [
"default",
[
Expand All @@ -19,5 +18,6 @@
],
// Enabled code coverage by default
"collectCoverage": true,
"coverageReporters": ["text", ["lcov", { "projectRoot": "../.." }]]
"coverageReporters": ["text", ["lcov", { "projectRoot": "../.." }]],
"coverageProvider": "v8"
}
6 changes: 5 additions & 1 deletion packages/web-rig/profiles/default/config/typescript.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@
// "moduleKind": "amd",
// "outFolderName": "lib-amd"
// },
{
"moduleKind": "commonjs",
"outFolderName": "lib-commonjs"
},
{
"moduleKind": "umd",
"outFolderName": "lib-umd"
Expand All @@ -58,7 +62,7 @@
* compiler option with the .mjs extension alongside (or instead of, if tsconfig.js
* specifies ESNext) the default compilation output.
*/
"emitMjsExtensionForESModule": true,
// "emitMjsExtensionForESModule": true,

/**
* If true, enable behavior analogous to the "tsc --build" command. Will build projects
Expand Down
4 changes: 2 additions & 2 deletions packages/web-rig/profiles/default/tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@
// "moduleDetection": "auto", /* Control what method is used to detect module-format JS files. */

/* Modules */
"module": "CommonJS", /* Specify what module code is generated. */
"module": "ESNext", /* Specify what module code is generated. */
"rootDir": "../../../../../src", /* Specify the root folder within your source files. */
// "moduleResolution": "node", /* Specify how TypeScript looks up a file from a given module specifier. */
"moduleResolution": "node", /* Specify how TypeScript looks up a file from a given module specifier. */
// "baseUrl": "./", /* Specify the base directory to resolve non-relative module names. */
// "paths": {}, /* Specify a set of entries that re-map imports to additional lookup locations. */
"rootDirs": [
Expand Down
8 changes: 0 additions & 8 deletions packages/web-rig/profiles/pure-css/config/typescript.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,6 @@
*/
"emitMjsExtensionForESModule": false,

/**
* Specifies the intermediary folder that tests will use. Because Jest uses the
* Node.js runtime to execute tests, the module format must be CommonJS.
*
* The default value is "lib".
*/
// "emitFolderNameForTests": "lib-commonjs",

/**
* If true and "isolatedModules" is configured in tsconfig.json, use a worker thread to run transpilation concurrently with type checking and declaration emit.
*/
Expand Down

0 comments on commit d675f1c

Please sign in to comment.